Skip to content

fix: main sketch file editor focus on layout reset #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix: main sketch file editor focus on layout reset #1676

merged 1 commit into from
Nov 29, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Nov 14, 2022 •
edited
Loading

Depends on #1662

Motivation

To activate the editor of the main sketch file when opening the workspace (with the sketch) for the first time.

Change description

The open sketch files contribution can now focus on the main sketch file.

Other information

To verify:

  • Get the attached sketch from Rightmost tab is selected by default #643
    1. Download this demonstration multi-file sketch: MultipleFiles.zip
  • Open the sketch. For example: "Arduino IDE.exe" ..\\..\\Documents\\Arduino\\MultipleFiles; the main sketch file has the focus, and the cursor blinks in the editor.
  • Select the other sketch file with // hello
  • Quit IDE2,
  • Start IDE2; the focus is not on the editor of the main sketch file.

Closes #643

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 15, 2022
@kittaakos kittaakos marked this pull request as ready for review November 15, 2022 07:22
AlbyIanna
AlbyIanna approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and code looks good 🚀

@per1234 per1234 linked an issue Nov 17, 2022 that may be closed by this pull request
Rightmost tab is selected by default #643
Closed
per1234
per1234 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #643

Thanks Akos!

@kittaakos kittaakos added the status: on hold Do not proceed at this time label Nov 22, 2022
@kittaakos kittaakos removed the status: on hold Do not proceed at this time label Nov 29, 2022
Base automatically changed from theia-1.31.1 to main November 29, 2022 08:39
@kittaakos kittaakos merged commit c0af1e6 into main Nov 29, 2022
@kittaakos kittaakos deleted the #643 branch November 29, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rightmost tab is selected by default
3 participants
@kittaakos @AlbyIanna @per1234